Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only square images? #7

Open
pmcrodrigues opened this issue Jul 30, 2018 · 3 comments
Open

Only square images? #7

pmcrodrigues opened this issue Jul 30, 2018 · 3 comments
Assignees
@nkolot
Labels
enhancement New feature or request

Comments

@pmcrodrigues
Copy link

Hi, nice work with this! I am correct in saying that this is only for square images? Are you planning to extend it to generic images?
@nkolot nkolot added the enhancement New feature or request label Jul 30, 2018
@nkolot
Copy link
Collaborator

nkolot commented Jul 30, 2018

It's fairly straightforward to make it work for rectangular images. Will do it some time this week.

@nkolot nkolot self-assigned this Jul 30, 2018
@jbohnslav
Copy link

What's the status on this?

@nkolot
Copy link
Collaborator

nkolot commented Oct 15, 2018

It appears that it's not as easy as I originally expected. Basically the forward pass is straightforward to implement, but for the backward pass there were some things in the code that were not clear how exactly it works. Feel free to fix it and submit a PR, I am quite busy currently, so I can't work on it.

@shirgur shirgur mentioned this issue Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolot nkolot

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbohnslav @pmcrodrigues @nkolot