Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin implementation #1

Merged
merged 26 commits into from
Jun 29, 2023
Merged

Plugin implementation #1

merged 26 commits into from
Jun 29, 2023

Conversation

danilobecke
Copy link
Owner

@danilobecke danilobecke commented Jun 16, 2023 •
edited
Loading

TODO

  • Description
  • Unit tests

@danilobecke danilobecke self-assigned this Jun 16, 2023
rogerluan
rogerluan requested changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review 🙏

lib/fastlane/plugin/tinifyme/actions/tinifyme_action.rb Outdated Show resolved Hide resolved
lib/fastlane/plugin/tinifyme/helper/tinifyme_helper.rb Outdated Show resolved Hide resolved
spec/tinifyme_action_spec.rb Show resolved Hide resolved
rogerluan
rogerluan requested changes Jun 29, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
fastlane-plugin-tinifyme.gemspec Outdated Show resolved Hide resolved
fastlane-plugin-tinifyme.gemspec Outdated Show resolved Hide resolved
fastlane-plugin-tinifyme.gemspec Outdated Show resolved Hide resolved
lib/fastlane/plugin/tinifyme/actions/tinifyme_action.rb Outdated Show resolved Hide resolved
spec/tinifyme_action_spec.rb Show resolved Hide resolved
spec/tinifyme_action_spec.rb Show resolved Hide resolved
spec/tinifyme_action_spec.rb Show resolved Hide resolved
spec/tinifyme_helper_spec.rb Outdated Show resolved Hide resolved
spec/tinifyme_helper_spec.rb Outdated Show resolved Hide resolved
rogerluan
rogerluan reviewed Jun 29, 2023
View reviewed changes
Gemfile Show resolved Hide resolved
rogerluan
rogerluan reviewed Jun 29, 2023
View reviewed changes
spec/tinifyme_helper_spec.rb Outdated Show resolved Hide resolved
lib/fastlane/plugin/tinifyme/helper/tinifyme_helper.rb Outdated Show resolved Hide resolved
spec/tinifyme_helper_spec.rb Outdated Show resolved Hide resolved
rogerluan
rogerluan approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@danilobecke danilobecke merged commit 6d5908c into main Jun 29, 2023
1 check passed
@danilobecke danilobecke deleted the plugin branch June 29, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerluan rogerluan rogerluan approved these changes

Assignees

@danilobecke danilobecke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danilobecke @rogerluan