V5: API changes #176
Merged
V5: API changes #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Rename `primaryColor` to `backgroundColor` and `secondaryColor` to `foregroundColor`.
ACHP
reviewed
Jan 17, 2020
danilowoz
force-pushed
the
v5
branch
2 times, most recently
from
5606874
to
a85f02a
Compare
BREAKING CHANGE: Renamed prop key `uniquekey` to `uniqueKey`
BREAKING CHANGE: Shift `ariaLabel` to `title` prop, the value remains
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primaryColorandsecondaryColorfor something more meaningful, maybebackgroundColorandforegroundColor;width/heightkeys and if it really necessary to apply onviewBoxattr its values;viewBoxis set up, the svg is truncated, see fix(native/svg.tsx): svg is truncated when using a ViewBox -react-native #173;uniquekeyfor something more meaningful, maybeid, orloadingId;preserveAspectRatio,className...