fix(svg): migrate defaultProps to default parameters #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaultProps is deprecated and will be removed from function components fix #298
|
|
shehi
previously approved these changes
Mar 3, 2023
|
@danilowoz , this looks good. Can you review, merge and release this please? |
danilowoz
previously approved these changes
Mar 5, 2023
|
@danilowoz . v6.2.0 apparently doesn't contain this fix. It seems release checks failed. Can you please check and make a release with this? Thanks. |
|
🎉 This PR is included in version 6.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultProps is deprecated and will be removed from function components
fix #298
Summary
There's an error because this lib is using
defaultPropsfor theSVG.tsxcomponent.defaultPropsare deprecated in function components.A simple fix is to migrate
defaultPropsto default JS parameters.Related Issue #[issue number]
#298 has been opened, thanks to @shehi for pointing out the file to update.
Any Breaking Changes
There is no breaking changes.
Checklist