-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
Hey Attila, thanks for your contribution! It works like a charm. Found just some minor improvements. Other than that, I think this is good to go. 👍 |
.git | ||
node_modules | ||
npm-debug.log* | ||
webhooks.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add
lib
folder to .dockerignore, which is generated when you build the project locally
Understood. I have made the commit with what you said and it seems to still work. I'm still investigating how you can control Docker from within a container. I want to use your project to auto-pull and restart Docker containers with the help of Docker Hub webhooks, but I want to run hooka from within a container, because my server uses CoreOS where everything has to be in a container. |
I was able to get I'm concerned of the last two lib mounts might be platform dependent, so I'm investigating a better way. |
I think there is no one-size-fits-all solution. I had to do this acrobatics to make it work under OSX with boot2docker:
|
Oh crap i didnt realize i committed that change that removes the Expose command from the dockerfile. I think that command may be needed for things like random port binding to work |
No problem. I've fixed it d53b719 |
Cool project you have.
I helped Dockerize it for you.
I'd suggest you create an account on https://hub.docker.com/ for creating automated builds of the project, so users wouldn't have to build the project themselves. Also you could add yourself as the MAINTAINER of the Dockerfile which I left out, because I don't know your name/email ( like what I did in my project: https://github.com/amcsi/szeremi/blob/master/Dockerfile#L2 ).