relationship data key should be undefined for undefined relationship

closes #13
danivek · Oct 28, 2016 · 12bc2cd · 12bc2cd
1 parent 135949e
commit 12bc2cd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/JSONAPISerializer.js b/lib/JSONAPISerializer.js
@@ -251,6 +251,11 @@ module.exports = class JSONAPISerializer {
    * @return {Object|Object[]} serialized relationship data.
    */
   serializeRelationship(rType, rData, rOptions, included) {
+    // No relationship data
+    if (rData === undefined) {
+      return undefined;
+    }
+
     // Empty relationship data
     if (!_.isNumber(rData) && _.isEmpty(rData)) {
       // Return [] or null

diff --git a/test/unit/JSONAPISerializer.test.js b/test/unit/JSONAPISerializer.test.js
@@ -148,6 +148,12 @@ describe('JSONAPISerializer', function() {
       },
     });
 
+    it('should return undefined for an undefined relationship data', function(done) {
+      const serializedRelationshipData = Serializer.serializeRelationship('articles', undefined);
+      expect(serializedRelationshipData).to.eql(undefined);
+      done();
+    });
+
     it('should return null for an empty single relationship data', function(done) {
       const serializedRelationshipData = Serializer.serializeRelationship('articles', {});
       expect(serializedRelationshipData).to.eql(null);