Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update native get #94

Merged
merged 2 commits into from
Nov 20, 2019
Merged

fix: update native get #94

merged 2 commits into from
Nov 20, 2019

Conversation

derekrliang
Copy link
Contributor

Object.hasOwnProperty doesn't seem to work in all situations

https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore#_get has updated their implementation and this is just updating it to the new one that fixes this issue.

`Object.hasOwnProperty` doesn't seem to work in all situations

https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore#_get has updated their implementation and this is just updating it to the new one that fixes this issue.
@coveralls
Copy link

coveralls commented Nov 19, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 324ebad on derekrliang:patch-1 into 57bb656 on danivek:master.

@danivek danivek force-pushed the patch-1 branch 2 times, most recently from 8aa8736 to d4b3f3f Compare November 20, 2019 11:32
Auteur :     danivek <danielo.kevin@gmail.com>
Date :       Wed Nov 20 12:28:32 2019 +0100
@danivek danivek merged commit 2b79a8c into danivek:master Nov 20, 2019
alechirsch pushed a commit to alechirsch/json-api-serializer that referenced this pull request Dec 10, 2019
* fix: update native get

`Object.hasOwnProperty` doesn't seem to work in all situations

https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore#_get has updated their implementation and this is just updating it to the new one that fixes this issue.
alechirsch added a commit to alechirsch/json-api-serializer that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants