Fix reading of bucket name and acl settings for S3 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized there was a similar problem with the |
leplatrem
changed the title
leplatrem
force-pushed
the
fix-bucket-name-setting
branch
from
5320fa2
to
f2f5eee
Compare
leplatrem
force-pushed
the
fix-bucket-name-setting
branch
from
f2f5eee
to
377a23b
Compare
leplatrem
added a commit
that referenced
this pull request
Nov 30, 2015
Fix reading of bucket name and acl settings for S3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of changing the documentation like #9, I decided to go for a small refactor of settings reading. This would pave the way for #8.
bucket_nameinstead ofbucketfrom_settings()