Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 Readme Changes #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

4 Readme Changes #21

wants to merge 1 commit into from

Conversation

Thovthe
Copy link

@Thovthe Thovthe commented Mar 18, 2022

Added:
A table of contents
A community software section that should allow closing Issue #8
A statement of general licensing intent

The diff looks a little weird at the bottom but I just formatted the name of RaspberryPi

Added:
A table of contents
A community software section that should allow closing Issue danjulio#8 
A statement of general licensing intent
@Thovthe Thovthe changed the title 3 Readme Changes 4 Readme Changes Mar 18, 2022
@danjulio
Copy link
Owner

Thanks for the suggestions. I have the following comments, questions about this PR.

  1. I'm not sure why that page needs a TOC. I don't see that it adds anything to navigation. Perhaps just additional wording in the first paragraph indicating the repository contains code and designs for the various platforms I have experimented with (honestly I should have split this into a bunch of repositories but don't want to know because of all the links pointing here).
  2. For the licensing section I think I'd rather say that there are a variety of licenses in use, including "as-is" and perhaps a note that some licenses are TBD.
  3. We should be explicit that the R-package relates to the ESP32 directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants