Details view sticks WC settings atop border

[dankamongmen]

Look at the details view here. What's up with the spacing? Did we let a tab through or something?

Note that this is also mentioned in #4. Use this bug to track the fix.

[dankamongmen]

It looks like there's a linefeed in the serial number.

[dankamongmen]

Normalizing all space characters to spaces improves things, but now the WC stuff is over by one character. nvme_id_ctrl allows up to 20 characters for the serial. sg likewise allows a serial to be up to 20 bytes. I think we've actually got 21 spaces for the S/N, so I think we've got an off-by-one here.

[dankamongmen]

We did indeed have an incorrect calculation of remaining space. That's fixed, but now we don't print it at all when the full 20 characters are being used. That's acceptable, I guess, but in the instance above we've just got trailing spaces. Trim them out at the point of the ioctl().

[dankamongmen]

I've got this fixed up for NVMe, but we should make it work the same way for regular disks. Lift out the presentation function and call it from sg_interrogate().

[dankamongmen]

Resolved.