Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support readline directly from ncdirect #1120

Closed
dankamongmen opened this issue Nov 17, 2020 · 1 comment
Closed

support readline directly from ncdirect #1120

dankamongmen opened this issue Nov 17, 2020 · 1 comment
Assignees
@dankamongmen
Labels
documentation Improvements or additions to documentation enhancement New feature or request question/research Further information is requested
Milestone
2.2.0

Comments

@dankamongmen
Copy link
Owner

Mixing ncdirect and readline is possible, but doing it correctly is not obvious, and it requires several steps. Instead, add an ncdirect_readline() and the necessary infrastructure for customization etc, most of it just thin wrappers atop libreadline.

Ensure libreadline works on windows and whatever cupertino is shipping these days first.
@dankamongmen dankamongmen self-assigned this Nov 17, 2020
@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request question/research Further information is requested labels Nov 17, 2020
@dankamongmen dankamongmen added this to the 2.2.0 milestone Jan 8, 2021
@dankamongmen
Copy link
Owner Author

This fix is present in 2.1.5. ncdirect_init() now initializes GNU Readline for safe use, unless the new NCDIRECT_OPTION_NO_READLINE is provided. I've updated the FAQ. Notcurses now requires GNU Readline 8.0+ at buildtime and runtime.

dankamongmen added a commit that referenced this issue Jan 8, 2021
@dankamongmen
ncdirect: prep readline for use #1120
68b340e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
documentation Improvements or additions to documentation enhancement New feature or request question/research Further information is requested
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@dankamongmen