Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend ncvisual_from_plane() to NCBLIT_PIXEL #1441

Closed
dankamongmen opened this issue Mar 22, 2021 · 9 comments · Fixed by #1776
Closed

extend ncvisual_from_plane() to NCBLIT_PIXEL #1441

dankamongmen opened this issue Mar 22, 2021 · 9 comments · Fixed by #1776
Assignees
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request nonfix closed without a successful fix (invalid, wontfix)
Milestone

Comments

@dankamongmen
Copy link
Owner

when ncvisual_from_plane() is run on a plane that holds a bitmap, we ought extract that as an NCBLIT_PIXEL ncvisual.

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 22, 2021
@dankamongmen dankamongmen self-assigned this Mar 22, 2021
@dankamongmen dankamongmen added the bitmaps bitmapped graphics (sixel, kitty, mmap) label Mar 24, 2021
@dankamongmen
Copy link
Owner Author

is this not basically ncplane_rgba()?

@dankamongmen
Copy link
Owner Author

dankamongmen commented Mar 31, 2021

yeah, ncplane_rgba() is called by ncvisual_from_plane(). this would be about making ncplane_rgba() work. but what does that mean?

  • we can't turn arbitrary glyphs into a bitmap...actually, shit, i guess maybe we can? nooooo...yes? no. sit on that.
  • we could expand ncplane_rgba() to store back pixels, but that's already what it does
  • we could actually extend ncvisual_from_plane() to work on sprixel planes, bypassing ncplane_rgba() and instead expanding the sprixel into an ncvisual...yes, i think that's what this bug is about

@dankamongmen
Copy link
Owner Author

when this is applied to a sixel, i think it ought return the quantized colors, so they can be inspected. to fill this from the actual sprixel, is what i'm saying. oooh it ought also reflect cutouts.

@dankamongmen dankamongmen added this to the 3.0.0 milestone Apr 10, 2021
@dankamongmen
Copy link
Owner Author

we also want NCBLIT_BRAILLE.

@dankamongmen
Copy link
Owner Author

I've started the Braille work (defining the inverse table) in dankamongmen/braille-reverse.

@dankamongmen
Copy link
Owner Author

ack! still need NCBLIT_PIXEL!

@dankamongmen
Copy link
Owner Author

depending on what we do with #1539, this might suddenly become very easy indeed.

@dankamongmen
Copy link
Owner Author

hrmmm, note that this is going to be very difficult in kitty now that we're using reflected composition -- we have no copy of the visual. hrmm.

@dankamongmen dankamongmen added the nonfix closed without a successful fix (invalid, wontfix) label Aug 5, 2021
@dankamongmen
Copy link
Owner Author

yeah, i don't think we can really do this anymore with our current kitty scheme. closing as nonfix.

@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.4.0 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request nonfix closed without a successful fix (invalid, wontfix)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant