Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max out sixel support settings #1528

Open
dankamongmen opened this issue Apr 12, 2021 · 4 comments
Open

max out sixel support settings #1528

dankamongmen opened this issue Apr 12, 2021 · 4 comments
Assignees
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request

Comments

@dankamongmen
Copy link
Owner

#1512 mentions that we might as well take the number of color registers, and maximum sixel size, up to the maximum reported supported values. note that there's a speed cost if we end up using all those extra color registers.

is there any other reason why we wouldn't want to do this? i feel that there's likely lost knowledge and esoteric arcana in this area.

@dankamongmen dankamongmen added the enhancement New feature or request label Apr 12, 2021
@dankamongmen dankamongmen self-assigned this Apr 12, 2021
@dankamongmen
Copy link
Owner Author

Remember, moving to support more than 256 colors means we'll have to move to a two-byte lookup in extraction.

@dankamongmen dankamongmen added bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation labels May 28, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone May 28, 2021
@dankamongmen
Copy link
Owner Author

dankamongmen commented May 28, 2021

having thought about this some more:

  • let's pump up the maximum allowed size
  • let's pump the color register count up to 256

but do not yet take the color count beyond 256, even if available. we need a faster quantizer to take good advantage of the extra space. on the other hand, the current quantizer absolutely requires at least 64 color registers, rejecting fewer in sixel_blit(), so getting that pumped up is kinda important.

@dankamongmen
Copy link
Owner Author

following the work in #1761 and #1469, we attempt to set the number of color registers to 256 before reading the number of color registers. we maybe ought try to set it to 64 first, in case it supports 64 but not 256 (remember, 64 is the minimum with our current algorithm)? we're not yet doing anything with sixel maxes.

@dankamongmen
Copy link
Owner Author

how is this distinct from #2141?

@dankamongmen dankamongmen removed this from the 3.0.0 milestone Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant