Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add undercurl as a style #1758

Closed
dankamongmen opened this issue Jun 12, 2021 · 6 comments · Fixed by #1787
Closed

add undercurl as a style #1758

dankamongmen opened this issue Jun 12, 2021 · 6 comments · Fixed by #1787
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request hax0rs-wanted looking to hack on notcurses? try these
Milestone

Comments

@dankamongmen
Copy link
Owner

At least kitty and wezterm, and probably others, support undercurl. Add NCSTYLE_UNDERCURL and the necessary code to support it, where available.

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request hax0rs-wanted looking to hack on notcurses? try these labels Jun 12, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Jun 12, 2021
@dankamongmen dankamongmen self-assigned this Jun 12, 2021
@dankamongmen
Copy link
Owner Author

it looks like both wezterm and kitty are using Smulx=\E[4\:%p1%dm, and alacritty also has this defined, though not in the terminfo database entry i have for it, odd.

kovidgoyal/kitty#3725
wez/wezterm#415

@dankamongmen
Copy link
Owner Author

So it looks like underline and undercurl (and double underline) are mutually exclusive.

That's actually good, because we want to be able to color the underline etc., which there's no way to do through the set_styles() interface. BUT we can add a function to configure the current underline state...except where would we then put this in rendered mode? it makes sense as a per-nccell thing...but we only have 4 bits free in the nccell.

hrmmmm. hrmmmmmmmmmmm.

for direct mode, it's trivial, since we just need a single current state, which we just pass through.

@dankamongmen
Copy link
Owner Author

2021-06-14-014502_1072x674_scrot

@WSLUser
Copy link

WSLUser commented Jun 14, 2021

Not relevant at the moment but for awareness Windows Terminal supports underline and double underline. There's also a request to get all the Kitty extended underlines supported including undercurl: microsoft/terminal#7228

@dankamongmen
Copy link
Owner Author

sweet! i hope to be compiling on Windows very soon.

does microsoft terminal run on anything but windows? if so, i can add support for it now.

@WSLUser
Copy link

WSLUser commented Jun 14, 2021

No, most of the VT support comes from the open console (aka conhost). Most of the code should be portable to Windows Terminal though. Also you'd need to use a different UI framework first or use something like Uno (I would be interested in seeing this particular Terminal become x-plat but MS can't support doing that, especially when there's still gaps in VT to fill still). Don't want to contaminate this issue further with anything unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request hax0rs-wanted looking to hack on notcurses? try these
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants