Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to teach quadblitter/sexblitter about non-interpolative #1763

Closed
dankamongmen opened this issue Jun 14, 2021 · 4 comments
Closed

need to teach quadblitter/sexblitter about non-interpolative #1763

dankamongmen opened this issue Jun 14, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@dankamongmen
Copy link
Owner

When we do a non-interpolative render, we ought blit it without lerping colors, I would think. Right? So either we need to pass that it's a non-interpolative render down into the blitters (i think this is already being done through blitterargs), or split them into interpolating and non-interpolating variants. i think the former is cleaner; there's not that much difference.

@joseluis, agreed?

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 14, 2021
@dankamongmen dankamongmen self-assigned this Jun 14, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Jun 14, 2021
@dankamongmen
Copy link
Owner Author

note here how we've introduced some new colors into this image, which is a 4-color palette in its native form:

2021-06-13-232524_1072x1417_scrot

@dankamongmen
Copy link
Owner Author

so how do we want to do this? right now in quadblitter we lerp together 2 or 3 with no transparency, or with transparency we lerp together everything that's not transparency. in sexblitter with transparency, we lerp together everything that's not transparent, and if there's no transparency, we minimize total distance and lerp accordingly.

for the transparency case (where we're locked to a single color), look for whatever color appears most frequently. if such a color exists, use it. otherwise...pick the one in the middle if there's an odd number? maybe we need look at surrounding cells? hrmm.

@dankamongmen
Copy link
Owner Author

it's interesting to note that, unless you're trying to keep the size down, higher blitter resolution is just going to probably make things look (a little) worse without interpolation, since you're kinda forcing an artificial upscaling given the limited number of colors per cell.

nonetheless, this is now done for quadblitter.

@dankamongmen
Copy link
Owner Author

sexblitter likewise honors nointerpolate now

2021-06-19-012419_1072x1417_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant