Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notcurses-info doesn't scroll enough when started close to the bottom #1994

Closed
dankamongmen opened this issue Jul 27, 2021 · 3 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dankamongmen
Copy link
Owner

notcurses-info works properly when started anywhere in the top portion of the terminal, or at the very bottom. there's a range at the bottom, however, where it doesn't scroll enough, and the capabilities section ends up covering the initial banner. this is presumably a flaw within the CLI model, not notcurses-info itself. see screenshot:

2021-07-27-032343_1047x1417_scrot

@dankamongmen dankamongmen added the bug Something isn't working label Jul 27, 2021
@dankamongmen dankamongmen self-assigned this Jul 27, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Jul 27, 2021
@dankamongmen
Copy link
Owner Author

so i launched one with 11 rows left below the launch line . there are 20 lines of output when stderr is redirected. this setup scrolls 5 too few lines (15 lines are used), and rasterize_scrolls() reports an order-10 scroll.

so we're ending up at bottom - 15, and want to be bottom - 20.

we had 11 lines free. 10 lines of scrolling ought have provided us with the 20 necessary lines. why are there only 15?

ahhhh, because we're not scrolling when we need to, but from where we started! that's definitely it. so what if we went to the bottom of the screen, scrolled, and returned to the expected first location? i think that's the thing to do, ought work.

@dankamongmen
Copy link
Owner Author

yep, that appears to work perfectly, huzzah!

@dankamongmen
Copy link
Owner Author

2021-07-27-034036_1047x1417_scrot

@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.4.0 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant