Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uniblock demo doesn't run in 80x25 #2018

Closed
dankamongmen opened this issue Aug 3, 2021 · 2 comments
Closed

uniblock demo doesn't run in 80x25 #2018

dankamongmen opened this issue Aug 3, 2021 · 2 comments
Assignees
@dankamongmen
Labels
bug Something isn't working
Milestone
2.4.0

Comments

@dankamongmen
Copy link
Owner

Similarly to #2015, it appears that 80x25 is insufficient for uniblock. It exits after 0 frames with error on such a geometry.
@dankamongmen dankamongmen added the bug Something isn't working label Aug 3, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Aug 3, 2021
@dankamongmen dankamongmen self-assigned this Aug 3, 2021
@dankamongmen
Copy link
Owner Author

it's failing at the progress bar creation.

dankamongmen added a commit that referenced this issue Aug 3, 2021
@dankamongmen
uniblock: always ensure there's enough space for the pbar #2018
22cc2b1
@dankamongmen
Copy link
Owner Author

Yeah, the pbar is gonna take a minimum of three rows, but we were only accounting for two when deciding on horizontal v vertical placement. Resolved and verified.

@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.4.0 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@dankamongmen