Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD_FFI_LIBRARY doesn't actually control anything #2519

Closed
dankamongmen opened this issue Jan 2, 2022 · 1 comment
Closed

BUILD_FFI_LIBRARY doesn't actually control anything #2519

dankamongmen opened this issue Jan 2, 2022 · 1 comment
Assignees
@dankamongmen
Labels
bug Something isn't working
Milestone
3.1.0

Comments

@dankamongmen
Copy link
Owner

@KristofferC , unless i'm missing something, BUILD_FFI_LIBRARY doesn't actually work to turn off notcurses-ffi. See Debian bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003009. I'm going to go ahead and add the necessary if()s etc., unless you can point out something I'm missing.
@dankamongmen dankamongmen added the bug Something isn't working label Jan 2, 2022
@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 2, 2022
@dankamongmen dankamongmen self-assigned this Jan 2, 2022
dankamongmen added a commit that referenced this issue Jan 2, 2022
@dankamongmen
[CMake] make BUILD_FFI_LIBRARY actually govern work/installation #2519
3f99e12
@dankamongmen
Copy link
Owner Author

ok i think we're good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@dankamongmen