Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigabrt in notcurses-view on invalid filename #378

Closed
dankamongmen opened this issue Feb 23, 2020 · 4 comments
Closed

sigabrt in notcurses-view on invalid filename #378

dankamongmen opened this issue Feb 23, 2020 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dankamongmen
Copy link
Owner

I was rendering a video in Openshot, not yet complete, h.264 using intel hardware encoder. I opened it in notcurses-view, and got a SIGABRT. I'd expect an error message, similar to what mpv would generate.

@dankamongmen dankamongmen added the bug Something isn't working label Feb 23, 2020
@dankamongmen dankamongmen added this to the 1.3.0 milestone Feb 23, 2020
@dankamongmen dankamongmen self-assigned this Feb 23, 2020
@dankamongmen
Copy link
Owner Author

Having difficulties reproducing this.

@dankamongmen
Copy link
Owner Author

Ahhh. I think what it might have been is that if we invoke notcurses-view with a missing file, it SIGABRTs out. I can't reproduce this with a partial file.

@dankamongmen dankamongmen changed the title sigabrt in notcurses-view on incomplete mp4 sigabrt in notcurses-view on invalid filename Mar 1, 2020
@dankamongmen
Copy link
Owner Author

OK, i forgot @grendello rewrote notcurses-view to use the C++ API. This is just failure to catch an exception bubbling up from the Visual constructor.

@dankamongmen
Copy link
Owner Author

Looks fixed:

[schwarzgerat](0) $ ./notcurses-view e 
Term: 80x74 xterm-256color (xterm with 256 colors)

 notcurses 1.2.2 by nick black et al
  74 rows, 80 columns (92.50KiB), 256 colors (direct)
  compiled with gcc-9.2.1 20200224
  terminfo from ncurses 6.2.20200212
  avformat 58.39.100
  avutil 56.41.100
  swscale 5.6.100
e: notcurses failed to create a new visual
[schwarzgerat](1) $ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant