Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling arrows aren't always placed at the right column on selector widget #388

Closed
dankamongmen opened this issue Feb 27, 2020 · 1 comment
Closed

Scrolling arrows aren't always placed at the right column on selector widget #388

dankamongmen opened this issue Feb 27, 2020 · 1 comment
Assignees
@dankamongmen
Labels
bug Something isn't working
Projects
widgetary aka the widget zoo
Milestone
1.3.0

Comments

@dankamongmen
Copy link
Owner

This can be noticed in the UI chapter of HTPwN. On selectors with very long headers or footers, we seem to offset the scroll arrows incorrectly. I think this means we won't be able to scroll with the mouse on such widgets. A small issue, but an annoying one.
@dankamongmen dankamongmen added the bug Something isn't working label Feb 27, 2020
@dankamongmen dankamongmen added this to the 1.3.0 milestone Feb 27, 2020
@dankamongmen dankamongmen self-assigned this Feb 27, 2020
@dankamongmen dankamongmen added this to Needs triage in widgetary aka the widget zoo via automation Feb 27, 2020
@dankamongmen dankamongmen moved this from Needs triage to Low priority in widgetary aka the widget zoo Feb 27, 2020
@dankamongmen
Copy link
Owner Author

dankamongmen commented Feb 29, 2020 •
edited

  • fix the placement
  • update screenshots in HtPwN
  • ensure mouse clicks land properly

dankamongmen added a commit that referenced this issue Feb 29, 2020
@dankamongmen
Selector: properly place scroll arrows #388
e6bbcd2 
When the selector body was being sized by the header
or footer (as opposed to option+desc length), our scroll
arrows are misplaced. They now land properly. Mouse
clicks are properly placed now, and screenshots have been
updated in the guide.
widgetary aka the widget zoo automation moved this from Low priority to Closed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
No open projects
widgetary aka the widget zoo
  
Closed
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@dankamongmen