Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ncplane_highgradient() #398

Closed
dankamongmen opened this issue Mar 8, 2020 · 3 comments
Closed

Add ncplane_highgradient() #398

dankamongmen opened this issue Mar 8, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dankamongmen
Copy link
Owner

We could work many more shades into our gradients if we used double halfblocks. Why aren't we?

@dankamongmen dankamongmen added the enhancement New feature or request label Mar 8, 2020
@dankamongmen dankamongmen added this to the 1.3.0 milestone Mar 8, 2020
@dankamongmen dankamongmen self-assigned this Mar 8, 2020
@dankamongmen
Copy link
Owner Author

We explicitly supply the EGC used for the gradient, so that doesn't fit with this idea really well. We could just arbitrarily break up FULL BLOCK, but that's unlike any other behavior. I think if we want this, we want to do it as its own function, ncplane_highgradient() or something.

If we do this, we want to update the calls in intro and sliding.

@dankamongmen dankamongmen changed the title Use double halfblocks for gradients Add ncplane_highgradient() Mar 8, 2020
@dankamongmen
Copy link
Owner Author

OLD:

2020-03-08-040230_1001x1417_scrot

NEW:

2020-03-08-040219_875x1417_scrot

@dankamongmen
Copy link
Owner Author

Look at piece 01 in each, and the improvement is obvious. I've also fixed up intro. Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant