Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncplot using NCGRID_8x1 doesn't seem to print top possible row #445

Closed
dankamongmen opened this issue Apr 6, 2020 · 4 comments
Closed

ncplot using NCGRID_8x1 doesn't seem to print top possible row #445

dankamongmen opened this issue Apr 6, 2020 · 4 comments
Assignees
@dankamongmen
Labels
bug Something isn't working
Projects
widgetary aka the widget zoo
Milestone
1.3.0

Comments

@dankamongmen
Copy link
Owner

Running notcurses-keyplot, hold down a key and allow the graph to grow to its maximum on the y-axis. In my setup, this is 17.00, and the bottommost plot doesn't print anything to the top row. Some others do. Observe the linked image. There are 6 lines for some, and only 5 for the top and bottom.

2020-04-06-012030_722x724_scrot
@dankamongmen dankamongmen self-assigned this Apr 6, 2020
@dankamongmen dankamongmen added the bug Something isn't working label Apr 6, 2020
@dankamongmen dankamongmen added this to Needs triage in widgetary aka the widget zoo via automation Apr 6, 2020
@dankamongmen dankamongmen moved this from Needs triage to High priority in widgetary aka the widget zoo Apr 6, 2020
@dankamongmen dankamongmen added this to the 1.3.0 milestone Apr 6, 2020
@dankamongmen
Copy link
Owner Author

much better!
2020-04-06-031838_722x857_scrot

@dankamongmen
Copy link
Owner Author

it's not perfect yet, though. start notcurses-keyplot and press a key once. everything will max out from [0..1], as expected (ie all will have all 6 rows filled). next, press a key twice quickly. the max is now 2, but the original samples remain all the way up. this remains the case until we get to a max of 6, at which point all suddenly correct themselves. instead, at 2 all the 1s ought be cut to 3 rows, and so on.

@dankamongmen
Copy link
Owner Author

This problem has been addressed. I think everything's pretty good now!

@dankamongmen
Copy link
Owner Author

2020-04-06-033151_722x857_scrot
2020-04-06-033002_722x857_scrot

dankamongmen added a commit that referenced this issue Apr 6, 2020
@dankamongmen
ncplot work #445 #448
c38981e 
Tighten up interval arithmetic. Render the plot immediately upon
creation so that the labels are visible. Properly perform domain
detection on miny by initializing it to 2^64-1. Handle plotting
when miny > maxy, as it now will be upon creation when using
domain detection (#448). Add spaces as the first element of each
glyph cycle (#445).
widgetary aka the widget zoo automation moved this from High priority to Closed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
No open projects
widgetary aka the widget zoo
  
Closed
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@dankamongmen