Split up notcurses/notcurses-core #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet; for some reason we stopped building FFmpeg symbols into |
|
I'm thinking I might redo the library constructors as weak symbol overrides, but this is the basic approach. |
This was referenced Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out the multimedia code and the rest of the library. The latter goes into
libnotcurses-core.so. The multimedia stuff goes intolibnotcurses.so.libnotcurses.sois build for all threeUSE_MULTIMEDIAconfigurations, though in the case ofnone, it is merely shims returning failure. Applications which never need the multimedia code ought link againstnotcurses-coreinstead ofnotcurses, so that a multimedia-free build can lacklibnotcurses.soin the future. Behavior ought be unchanged for existing programs. Closes #339.