popen() wants pclose() not fclose()

dankamongmen · Mar 4, 2022 · 0c9879a · 0c9879a
1 parent 16dd1bd
commit 0c9879a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/omphalos/popen.c b/src/omphalos/popen.c
@@ -73,10 +73,10 @@ int popen_drain(const char *cmd){
 	}
 	if(!feof(fd)){
 		diagnostic("Error reading from '%s' (%s?)",cmd,strerror(errno));
-		fclose(fd);
+		pclose(fd);
 		return -1;
 	}
-	if(fclose(fd)){
+	if(pclose(fd)){
 		diagnostic("Error running '%s'",cmd);
 		return -1;
 	}
@@ -105,13 +105,13 @@ char *spopen_drain(const char *cmd){
 			}
 		}
 		if(!feof(fd)){
-		       if(o < s){
+		  if(o < s){
 				diagnostic("Error reading from '%s' (%s?)",cmd,strerror(errno));
-				fclose(fd);
+				pclose(fd);
 				free(buf);
 				return NULL;
-		       }
-		}else if(fclose(fd)){
+		  }
+		}else if(pclose(fd)){
 			diagnostic("Error running '%s'",cmd);
 			free(buf);
 			return NULL;