Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kriging example #2080

Closed
dankelley opened this issue Apr 25, 2023 · 3 comments
Closed

remove kriging example #2080

dankelley opened this issue Apr 25, 2023 · 3 comments

Comments

@dankelley
Copy link
Owner

I see a failure in the CRAN checks (https://cran.r-project.org/web/checks/check_results_oce.html). It's because of a warning that is converted to an error. (see below).

My rhub checks did not reveal this problem. In case this will cause CRAN rejection, I'm going to remove this example so it won't appear in future versions.

> if (requireNamespace("automap", quietly=TRUE) && requireNamespace("sf", quietly=TRUE)) {
+ gsKriging <- sectionSmooth(gs, "kriging", xr=50, yr=200)
+ plot(gsKriging, which="temperature")
+ mtext("sectionSmooth(..., method=\"kriging\")", line=0.5)
+ }
OMP: Warning #96: Cannot form a team with 8 threads, using 2 instead.
OMP: Hint Consider unsetting KMP_DEVICE_THREAD_LIMIT (KMP_ALL_THREADS), KMP_TEAMS_THREAD_LIMIT, and OMP_THREAD_LIMIT (if any are set).
@dankelley
Copy link
Owner Author

Fixed in "develop" branch, commit 46774d3

@dankelley
Copy link
Owner Author

In "develop" commit f039406, the possibly-problematic example code is simply commented-out. That will ensure that the problem doesn't go away. Click 'Details' below for some notes on my reasoning.

oce and kriging

With version 1.8-0 we have a linux/debian check yielding an error (converted
from a warning about number of cores being used). I did some web searches, and
found Rdatatable/data.table#3300, which makes me think
oce will get a "change or else" message.

Presently I am using \dontrun{} but I need to learn whether that is obeyed. Here
are some references to check:

The last of these has "I clarified the docs. Generally, now if you don't want to
run tests on CRAN \dontrun{} is more likely to work, but using \dontrun{} may
cause initial submission to fail." from Hadley. I am going to simply comment it
out, which I know will avoid the problem.

@dankelley
Copy link
Owner Author

I just noticed that this problem has disappeared on the CRAN report page. Still, the code change is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant