This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
Dank memer new update + few suggestions #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first suggestion is a major update and the remaining 3 are performance improvement/efficiency improvement udpates.
As you know the gifting system has changed in dankmemer with the new update. Many solutions are available
Suggestion : Custom commands should be executed first.
The cooldown's can be stored in a local text file. So that next time dank grinder is opened it can just read the local file and continue the commands accordingly. Maybe you can adjust such that only items with long cooldowns > 30 minutes are stored in local file. I mean, the cooldowns of pls dig, pls fish etc. need not be stored. But cooldowns like work cooldown, pls use apple (36 hours), such items cooldown can be stored locally. ( This can increase the efficiency of this grinder a lot.)
I saw that the bot automatically check for number of items you have and gift them accordingly. But a small bug that even when there is 0 items, it's trying to gift. ex : pls gift 0 banknotes @main . It could be rectified easily and could save a lot of time.