Silence unused var warnings from Encode #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue Perl/perl5#17536 and dankogai#146 and dankogai#140 and dankogai#143 Aliasing exposes the 'ix' variable. Since the code does not change behavior based on the alias (which is what aliases are for) the functions do not access the 'ix' variable, which throws warnings. Since Encode is core they need to be fixed. The correct solution to this is to declare the ix variable unused by using the PERL_UNUSED_VAR(ix); macro, which this patch does.
|
Thank you! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 2, 2020
3.05 2020/03/18 04:56:12
! Encode.pm
Address Tiny change for Encode.pm from David Levine
We do some compiled perl, and @inc is not always defined,
so it throws a warning.
<BN8PR12MB3153AEAF99EC08DB1E69A458A4FA0@BN8PR12MB3153.namprd12.prod.outlook.com>
! lib/Encode/Guess.pm
fix RT#131359: Encode::Guess: incomplete error messsage
https://rt.cpan.org/Public/Bug/Display.html?id=131359
3.04 2020/03/10 22:29:50
! Encode.pm
Bump version to make bleadperl happy
<0036284d-87ac-a021-0ba9-44bc972e88ab@khwilliamson.com>
3.03 2020/03/02 04:34:34
! Encode.pm Encode.xs
pulled: Stop using deprecated function
dankogai/p5-encode#148
! Encode.xs
pulled: Silence unused var warnings from Encode
dankogai/p5-encode#147
3.02 2019/12/25 09:23:21
! t/whatwg-aliases.t
drop RELEASE_TESTING since Pumpking also uses it.
Perl/perl5#17382
! bin/enc2xs
Pulled: enc2xs: Add environment variable to suppress comments
dankogai/p5-encode#145
! t/enc_utf8.t
Pulled: fixup enc_utf8.t for ONLY_PRAGMA_WARNINGS
dankogai/p5-encode#142
! Encode/encode.h
Pulled: Fix linker errors
dankogai/p5-encode#141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue Perl/perl5#17536 and
#146 and
#140 and
#143
Aliasing exposes the 'ix' variable. Since the code does not
change behavior based on the alias (which is what aliases are for)
the functions do not access the 'ix' variable, which throws
warnings. Since Encode is core they need to be fixed.
The correct solution to this is to declare the ix variable
unused by using the PERL_UNUSED_VAR(ix); macro, which
this patch does.