Docs updates #155
Docs updates #155
Conversation
This clarifies why to avoid encode_utf8() and decode_utf8() and expands on the problem of decoding “utf8”.
|
|
||
| .. or croak: | ||
|
|
||
| decode("UTF-8", "\xf8\x88\x80\x80\x80", 9); |
There was a problem hiding this comment.
Hello! Can you put human readable constant names as a third check argument instead of magic number 9?
There was a problem hiding this comment.
I was shooting for consistency with the other examples above, which give 1 instead of FB_CROAK. Should I update those as well?
There was a problem hiding this comment.
I've overlooked this. 9 must be DIE_ON_ERR|LEAVE_SRC. I'll fix it.
There was a problem hiding this comment.
Maybe FB_CROAK instead of DIE_ON_ERR for consistency?
| @@ -499,30 +499,32 @@ followed by C<encode> as follows: | |||
|
|
|||
| $octets = encode_utf8($string); | |||
|
|
|||
| B<WARNING>: L</UTF-8 vs. utf8 vs. UTF8|This function can produce invalid UTF-8!> | |||
There was a problem hiding this comment.
Have you checked output of your change?
I think that this hyperlink does not work.
POD syntax for hyperlinks is L<text|name/section> which looks like you swapped text and link parts.
| =head3 decode_utf8 | ||
|
|
||
| $string = decode_utf8($octets [, CHECK]); | ||
|
|
||
| B<WARNING>: L</UTF-8 vs. utf8 vs. UTF8|This function accepts invalid UTF-8!> |
There was a problem hiding this comment.
Also need to fix this hyperlink.
This clarifies why to avoid encode_utf8() and decode_utf8() and expands
on the problem of decoding “utf8”.