New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close tab on mouse middle click #46

Merged
merged 1 commit into from Dec 6, 2011

Conversation

Projects
None yet
2 participants
@ndbroadbent
Copy link

ndbroadbent commented Nov 25, 2011

I hope this is the correct solution, please let me know if I've done this wrong.

@timfel

This comment has been minimized.

Copy link

timfel commented Nov 26, 2011

Could you extend the condition in https://github.com/redcar/redcar/blob/master/plugins/application_swt/lib/swt/vtab_label.rb#L104 instead?

You can just add to the if-clause, or refactor a little, either way works for me.

@ndbroadbent

This comment has been minimized.

Copy link

ndbroadbent commented Nov 26, 2011

Good point, that would be better. Will do

On Sun, Nov 27, 2011 at 3:59 AM, Tim Felgentreff
reply@reply.github.com
wrote:

Could you extend the condition in https://github.com/redcar/redcar/blob/master/plugins/application_swt/lib/swt/vtab_label.rb#L104 instead?

You can just add to the if-clause, or refactor a little, either way works for me.


Reply to this email directly or view it on GitHub:
#46 (comment)

@ndbroadbent

This comment has been minimized.

Copy link

ndbroadbent commented Dec 3, 2011

Hi, I've updated the commit to extend the condition.

Thanks

timfel added a commit that referenced this pull request Dec 6, 2011

@timfel timfel merged commit 08acf4a into danlucraft:master Dec 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment