Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACSF and split frequency plots take a REALLY long time #147

Open
roblanf opened this issue Dec 5, 2019 · 5 comments
Open

ACSF and split frequency plots take a REALLY long time #147

roblanf opened this issue Dec 5, 2019 · 5 comments

Comments

@roblanf
Copy link
Collaborator

roblanf commented Dec 5, 2019

There must be something we can do about this. I'm trying out some test data and it's pretty intolerable...

@danlwarren
Copy link
Owner

danlwarren commented Dec 5, 2019 via email

@roblanf
Copy link
Collaborator Author

roblanf commented Dec 5, 2019

First let's check if it's the drawing time or the calculation time. If it's the calculation time we might need to see if we can draft in some help to speed it up. I'm fairly sure that whatever machinery is used for 'rf.dist()' is the same as would be used for these. So I think in principle the calculations don't need to take longer than a call to rf.dist() for the same trees. It's probably just that our code is really inefficient...

@danlwarren
Copy link
Owner

danlwarren commented Dec 5, 2019 via email

@roblanf
Copy link
Collaborator Author

roblanf commented Dec 5, 2019

We might be getting our wires crossed here. I'm talking about the sliding window and cumulative plots.

@danlwarren
Copy link
Owner

danlwarren commented Dec 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants