Bugfix/macos issue 87 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added .idea directory to .gitignore (JetBrains Rider)
- SCARD_READERSTATE -> using int instead of IntPtr
Make test program more verbose.
This reverts commit 70e4902.
- Updated to the latest supported System.Reactive 4.1.5 - Added System.ValueTuple 4.5.0 as requirement for all projects depending on PCSC.Reactive - Updated all NuGet packages (NUnit, FAKE, FakeItEasy, ...)
- Converted most examples projects to .NetCore 2.2 apps
Added software requirements in README.md.
- Changed IntPtr to int (uint32_t).
MacOS does not allow Direct/Unset for Connect(...)
- Timeout IntPtr -> int (must not throw on -1)
According to pcsclite.h (MacOSX header files) the two data structures SCARD_READERSTATE and SCARD_IO_REQUEST are using the C #pragma pack(1).
paket.exe produces build errors (File or Directory not found ... blabla). To fix the build failure I decided to use Microsoft's PackageReference.
- RxMonitorReaderEventsWpf requires .Net Core 3.0 (preview) + WPF - Using a separate solution file for WPF projects (because they will not compile on Linux / MacOSX) - Moved Nunit test projects to .Net Core test projects
- Removed old FAKE 4 style build system - Removed Paket command line tool (will be downloaded by FAKE anyway)
- Using 'dotnet test' to run all NUnit tests.
On Linux you may have to add the following lines into your .profile or .bashrc file:
if [ -d "$HOME/.dotnet/tools" ] ; then
PATH="$HOME/.dotnet/tools:$PATH"
fi
- .NET Framework Reference Assemblies via NuGet (https://stu.dev/dotnet-framework-reference-assemblies-via-nuget/)
Corrected cast error (Overflow exception)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version 4.1.0 fixing #87, #88, #90