Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing base URL when parsing Github release atom feeds #168

Closed
francishart opened this issue Apr 11, 2016 · 2 comments
Closed

Missing base URL when parsing Github release atom feeds #168

francishart opened this issue Apr 11, 2016 · 2 comments

Comments

@francishart
Copy link

There seems to be a bug when parsing a Github release feed (example: https://github.com/danmactough/node-feedparser/releases.atom), the first entry is missing the base URL however all other entries looks fine.

First entry:

{
    "title": "v1.1.3",
    "description": "<p>Bump version: v1.1.3</p>",
    "summary": null,
    "date": "2015-06-12T04:08:25.000Z",
    "pubdate": "2015-06-12T04:08:25.000Z",
    "pubDate": "2015-06-12T04:08:25.000Z",
    "link": "/danmactough/node-feedparser/releases/tag/v1.1.3",
    "guid": "tag:github.com,2008:Repository/2392967/v1.1.3",
    "author": "danmactough",
    "comments": null,
   ...

Second entry:

{
    "title": "v1.1.2",
    "description": "<p>Bump version: v1.1.2</p>",
    "summary": null,
    "date": "2015-06-02T22:38:23.000Z",
    "pubdate": "2015-06-02T22:38:23.000Z",
    "pubDate": "2015-06-02T22:38:23.000Z",
    "link": "https://github.com/danmactough/node-feedparser/releases/tag/v1.1.2",
    "guid": "tag:github.com,2008:Repository/2392967/v1.1.2",
    "author": "danmactough",
    "comments": null,
    ...

Tested with the iconv example code, feedparser 1.1.4.

@liptonista
Copy link

liptonista commented Oct 7, 2017

Same here. But this can be avoided by adding feedurl option to new FeedParser as written in README.

I think one of the reasons of the missing base URL is that reresolve method does not handle nodes recursively.

notok added a commit to notok/hubot-rss-reader that referenced this issue Nov 3, 2017
Feedparser sometimes fails to resolve relative URLs.
(e.g. [Github's release atom feed](https://github.com/shokai/hubot-rss-reader/releases.atom).
 refer to: [feedparser's issue](danmactough/node-feedparser#168))
Adding `feedurl` option as a workaround of this issue as written in [README](https://github.com/danmactough/node-feedparser#options).
@danmactough
Copy link
Owner

fixed via 6cf0cf7 and published in v2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants