Fixed #827 (Tokenizer: sizeof is incorrectly simplified)

danmar · Oct 18, 2009 · 50e542c · 50e542c
1 parent 58790ed
commit 50e542c
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/src/tokenize.cpp b/src/tokenize.cpp
@@ -1039,7 +1039,7 @@ void Tokenizer::setVarId()
         if (Token::Match(tok, "class|struct %type% :|{|;"))
             continue;
 
-        if (Token::Match(tok, "else|return|typedef|delete"))
+        if (Token::Match(tok, "else|return|typedef|delete|sizeof"))
             continue;
 
         if (Token::Match(tok, "const|static|extern|public:|private:|protected:"))
@@ -1537,7 +1537,6 @@ void Tokenizer::simplifySizeof()
                     tok->insertToken("(");
                     tempToken->insertToken(")");
                     Token::createMutualLinks(tok->next(), tempToken->next());
-                    setVarId();
                     break;
                 }
             }

diff --git a/test/testsimplifytokens.cpp b/test/testsimplifytokens.cpp
@@ -66,6 +66,7 @@ class TestSimplifyTokens : public TestFixture
         TEST_CASE(sizeof8);
         TEST_CASE(sizeof9);
         TEST_CASE(sizeof10);
+        TEST_CASE(sizeof11);
         TEST_CASE(casting);
 
         TEST_CASE(template1);
@@ -788,6 +789,38 @@ class TestSimplifyTokens : public TestFixture
         ASSERT_EQUALS(code, tok(code));
     }
 
+    void sizeof11()
+    {
+        // ticket #827
+        const char code[] = "void f()\n"
+                            "{\n"
+                            "    char buf2[4];\n"
+                            "    sizeof buf2;\n"
+                            "}\n"
+                            "\n"
+                            "void g()\n"
+                            "{\n"
+                            "    struct A a[2];\n"
+                            "    char buf[32];\n"
+                            "    sizeof buf;\n"
+                            "}";
+
+        const char expected[] = "void f ( ) "
+                                "{"
+                                " char buf2 [ 4 ] ;"
+                                " 4 ; "
+                                "} "
+                                ""
+                                "void g ( ) "
+                                "{"
+                                " struct A a [ 2 ] ;"
+                                " char buf [ 32 ] ;"
+                                " 32 ; "
+                                "}";
+
+        ASSERT_EQUALS(expected, tok(code));
+    }
+
     void casting()
     {
         {