Skip to content

Commit

Permalink
wxwidgets.cfg: Improved support for wxString member functions.
Browse files Browse the repository at this point in the history
  • Loading branch information
orbitcowboy committed Aug 25, 2019
1 parent 931587c commit c8b7b40
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
8 changes: 8 additions & 0 deletions cfg/wxwidgets.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4471,6 +4471,7 @@
<function name="Length" yields="size"/>
<function name="Len" yields="size"/>
<function name="empty" yields="empty"/>
<function name="Empty" yields="empty"/>

This comment has been minimized.

Copy link
@versat

versat Aug 25, 2019

Collaborator

Empty is already configured with action clear above. It really removes all elements as far as i understand, so the action should be clear and not empty which just checks if the container is empty.

This comment has been minimized.

Copy link
@orbitcowboy

orbitcowboy Aug 26, 2019

Author Collaborator

Thanks! Adjusted with 2b41297

<function name="IsEmpty" yields="empty"/>
<function name="IsNull" yields="empty"/>
<function name="erase" action="erase"/>
Expand All @@ -4482,9 +4483,16 @@
<function name="Prepend" action="change"/>
<function name="replace" action="change"/>
<function name="Replace" action="change"/>
<function name="LowerCase" action="change"/>
<function name="UpperCase" action="change"/>
<function name="MakeCapitalized" action="change"/>
<function name="MakeLower" action="change"/>
<function name="MakeUpper" action="change"/>
<function name="UpperCase" action="change"/>

This comment has been minimized.

Copy link
@versat

versat Aug 25, 2019

Collaborator

I have intentionally not added these functions because they do not change the size of the container (number of elements) as far as i understand.

This comment has been minimized.

Copy link
@orbitcowboy

orbitcowboy Aug 26, 2019

Author Collaborator

Thanks! Adjusted with 2b41297

<function name="reserve" action="change-internal"/>
<function name="shrink_to_fit" action="change-internal"/>
<function name="Shrink" action="change-internal"/>
<function name="Strip" action="change-internal"/>

This comment has been minimized.

Copy link
@versat

versat Aug 25, 2019

Collaborator

Strip is already configured with action change. As far as i understand it could remove elements, so it is not only an internal change but really could change the size of the container (number of elements)

This comment has been minimized.

Copy link
@orbitcowboy

orbitcowboy Aug 26, 2019

Author Collaborator

Thanks! Adjusted with 2b41297

<function name="Alloc" action="change-internal"/>
<function name="Strip" action="change"/>
<function name="Trim" action="change"/>
Expand Down
1 change: 1 addition & 0 deletions test/cfg/wxwidgets.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// No warnings about bad library configuration, unmatched suppressions, etc. exitcode=0
//

#include <wx/wx.h>
#include <wx/app.h>
#include <wx/log.h>
#include <wx/filefn.h>
Expand Down

0 comments on commit c8b7b40

Please sign in to comment.