cli/cmdlineparser.cpp: fix cli --help, --platform=avr8 misinformation. #1075
Conversation
Fixes: Removed hard coded avr8 platform and moved it into a platform file (avr8.xml). 61e4720
|
Maybe this PR should wait until https://trac.cppcheck.net/ticket/8242#comment:5 has been addressed? |
| " * unspecified\n" | ||
| " Unknown type sizes\n" | ||
| " --platform=<file>\n" | ||
| " Uses types and sizes from platform file:\n" | ||
| " * platforms/avr8.xml\n" |
There was a problem hiding this comment.
If the stuff is in a separate file, I would recommend to not mention it in the --help output.
There was a problem hiding this comment.
Why not? What's the difference between library and platform files?
There was a problem hiding this comment.
in the help for --library we don't list what cfg files there are.
|
Could you review this. I have addressed https://trac.cppcheck.net/ticket/8242#comment:5 so you can now use --platform=avr8. |
That is working for me (using my own cygwin/mingw build). I agree to PKEuS' comment that we shouldn't list those external files. That way it's more comfortable to add/remove/rename platforms, see https://trac.cppcheck.net/ticket/8424 |
|
cppcheck could iterate over the available files and add them to the list? |
|
it sounds OK to iterate over the available platforms and list them all. I close this PR, feel free to create a new PR that iterates and show all available platforms. |
Fixes: Removed hard coded avr8 platform and moved it into a platform file (avr8.xml).
61e4720