added MinGW to CI and fixed local MinGW build #3826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
LDFLAGS
from the documentation since theMakefile
sets it implicitly.Somehow the MinGW setup in the CI contains
which
anduname
which are not available if I install MinGW locally. So even though the build works in the CI we need to adjust the detection and configuration in theMakefile
. These are more reasons which would justify dropping theMakefile
in favor of CMake (but I am not prepared to do that for several reasons...yet).This is in preparation of natively running daca@home on Windows via MinGW.