fix html report generation with pygments >= 2.12.0

[pattop]

pygments 2.12.0 changed the signature of the HtmlFormatter.wrap()
method. As we don't actually care about the arguments to wrap we can
use packing/unpacking to maintain compatability with older versions of
pygments.

[pattop]

Looks like this was caused by pygments/pygments@992fa6c.

[firewave]

Thanks for your contribution.

You also needs to remove the fixated version from the CI (added in #4068) and make sure it works with pygments version <= 2.12.0.

See also https://trac.cppcheck.net/ticket/11022.

[pattop]

I'm no a python expert (know enough to be dangerous), but I think packing/unpacking the arguments is a straightforward way of maintaining backward compatibility. No idea if this works with all versions of python you need to support though.

[firewave]

I'm no a python expert (know enough to be dangerous), but I think packing/unpacking the arguments is a straightforward way of maintaining backward compatibility.

I wasn't even aware of that. My Python knowledge is very barebones and un-modern. Looks good though. :D

No idea if this works with all versions of python you need to support though.

That's what we have the CI for. Fortunately Python 2.7 still has an older version so that will verify if it works (for some reason Python 3.5 also failed although it should have the latest pygments package). In all other cases we pull the latest with pip.

BTW how do you want to be credited (i.e. entry in AUTHORS)?

[firewave]

Python 2.7:

Collecting pygments
  Downloading Pygments-2.5.2-py2.py3-none-any.whl (896 kB)
Installing collected packages: pygments
Successfully installed pygments-2.5.2

Python 3.5:

Collecting pygments
  Downloading Pygments-2.11.2-py3-none-any.whl (1.1 MB)
Installing collected packages: pygments
Successfully installed pygments-2.11.2

[pattop]

BTW how do you want to be credited (i.e. entry in AUTHORS)?

Patrick Oppenlander patrick.oppenlander@gmail.com

Thanks,

Patrick