Fixed TODO-test for CheckCondition::checkBadBitmaskCheck by handling functions return bool.

[simartin]

Hi,

This patch fixes a TODO test case by properly detecting "x | non_null_integer" patterns returned in boolean functions. Thanks to consider merging.

Cheers,
Simon

[PKEuS]

This fix does not fix the false negative entirely, because I guess that it fails if the return is in an inner scope.

[simartin]

Patch updated to show that inner scopes are handled (if I properly understood PKEuS' comment)

[PKEuS]

No, you misunderstood me. I was not talking about typedefs, I was more talking about inner scopes in the function like if/for/while. Does it work for code like this?

if(z) return x|0x02;

[simartin]

Thanks, this is clear now, and you were right, this case was not supported. Hence the updated patch.