Code refactoring #49
Merged
Code refactoring #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it just uses double quotes instead of the %q notation.
The `match` method generates a MatchData object, making it slower than the `=~` operator [1]. Since this MatchData object is not being used, it makes sense to switch to `=~`. [1]: http://stackoverflow.com/a/11908214/1160916
Changes include: * Using Minitest::Test instead of Test::Unit * Updating mocha to the latest version * Using test_construct since test-construct is no longer being maintained * Fixing 3 broken tests
|
Awesome thanks for the effort. I will review this soon and get it all merged in. I appreciate the work and effort. |
|
awesome looks great merged in. Really appreciate the cleanup. |
|
Thanks 馃槃 I thank you for this incredible gem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using Churn in a gem of mine and thought I needed a new feature. While developing that feature, I ended up refactoring a bit of Churn's code. In the end, I realized I didn't need that feature after all 馃槕
However, not every effort has to go to waste. I hope some of these changes are useful.
I apologize for all the whitespace fixing, but my text editor does that for me 馃槅 Every file I touched had its whitespace fixed, so I bundled all that into a single commit.