New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resque support #177
Add resque support #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great thanks
Coverband.start | ||
end | ||
|
||
module Coverband |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice this is very clean, well done
merge when ever, I am not concerned on the -0.2% test change |
Thanks! Do you think we can ask the company that was having the memory issues with reque to try this out? |
yeah if we did a 4.0.2.alpha release I could ask him to run another test with it. The dev seems pretty interested in getting things sorted. If we do an alpha release I normally update coverband_demo to be on the latest test release. I just made you a collaborator on that repo. I think you have rights to publish to Rubygems as well. If not let me know and I can try to fix that, I am also happy to do the release if you like. |
I noticed the resque test is sporadically failing. I'll try to figure out that issue and then do an alpha release? Thanks for the invite to coverband_demo! |
cool makes sense to try to fix test if we can first... I am working on another feature, but may or may not make 4.0.2 release. We will see how long it takes to get some more feedback about resque and if we can reproduce the memory lead. I am working on adding Gem coverage support via an optional flag. Reported as a new tab on the UI that lists all gems loaded and basic percentage usage per gem. |
Sounds good. That sounds like an amazing feature! So many gems that go
unused in big rails projects.
…On Sun, Jan 27, 2019 at 3:34 PM Dan Mayer ***@***.***> wrote:
cool makes sense to try to fix test if we can first... I am working on
another feature, but may or may not make 4.0.2 release. We will see how
long it takes to get some more feedback about resque and if we can
reproduce the memory lead.
I am working on adding Gem coverage support via an optional flag. Reported
as a new tab on the UI that lists all gems loaded and basic percentage
usage per gem.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#177 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF6EgPkI4uqTCmeg9Q-Yvtck_v5VjE0ks5vHg1lgaJpZM4aUXP1>
.
|
Out of box support for resque. Current implementation will report to redis for every job execution.