Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resque support #177

Merged
merged 1 commit into from Jan 27, 2019
Merged

Add resque support #177

merged 1 commit into from Jan 27, 2019

Conversation

kbaum
Copy link
Collaborator

@kbaum kbaum commented Jan 26, 2019

Out of box support for resque. Current implementation will report to redis for every job execution.

@kbaum kbaum requested a review from danmayer January 26, 2019 20:21
Copy link
Owner

@danmayer danmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thanks

Coverband.start
end

module Coverband
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this is very clean, well done

@danmayer
Copy link
Owner

merge when ever, I am not concerned on the -0.2% test change

@kbaum kbaum merged commit 8c6a801 into master Jan 27, 2019
@kbaum
Copy link
Collaborator Author

kbaum commented Jan 27, 2019

Thanks! Do you think we can ask the company that was having the memory issues with reque to try this out?

@danmayer
Copy link
Owner

yeah if we did a 4.0.2.alpha release I could ask him to run another test with it. The dev seems pretty interested in getting things sorted.

If we do an alpha release I normally update coverband_demo to be on the latest test release. I just made you a collaborator on that repo. I think you have rights to publish to Rubygems as well. If not let me know and I can try to fix that, I am also happy to do the release if you like.

@kbaum
Copy link
Collaborator Author

kbaum commented Jan 27, 2019

I noticed the resque test is sporadically failing.

#178

I'll try to figure out that issue and then do an alpha release?

Thanks for the invite to coverband_demo!

@danmayer
Copy link
Owner

cool makes sense to try to fix test if we can first... I am working on another feature, but may or may not make 4.0.2 release. We will see how long it takes to get some more feedback about resque and if we can reproduce the memory lead.

I am working on adding Gem coverage support via an optional flag. Reported as a new tab on the UI that lists all gems loaded and basic percentage usage per gem.

@kbaum
Copy link
Collaborator Author

kbaum commented Jan 27, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants