Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of file path functionality #308

Closed
wants to merge 7 commits into from
Closed

Conversation

kbaum
Copy link
Collaborator

@kbaum kbaum commented Aug 3, 2019

  • File hashing converts to absolute path before hashing
  • Both relative and absolute file conversion cache results
  • Moved file path helper functionality to classes to make more testable and separate concerns

Memory Impact

Before:

bundle exec rake benchmarks:run_big
D, [2019-08-04T21:09:07.973428 #51553] DEBUG -- : using default configuration
Total allocated: 113157075 bytes (821933 objects)
Total retained:  666256 bytes (4015 objects)

allocated memory by gem
-----------------------------------
  49874880  coverband/lib
  30916130  json
  21175024  redis-4.1.2
  11191041  other

After

D, [2019-08-04T21:13:09.517425 #52381] DEBUG -- : using default configuration
Total allocated: 109734929 bytes (821922 objects)
Total retained:  666256 bytes (4015 objects)

allocated memory by gem
-----------------------------------
  49874880  coverband/lib
  30916130  json
  19585080  redis-4.1.2
   9358839  other

@kbaum
Copy link
Collaborator Author

kbaum commented Aug 5, 2019

This has been merged in as part of another PR.

@kbaum kbaum closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant