Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hmset and hgetall to pass args #330

Merged
merged 7 commits into from
Oct 7, 2019
Merged

Use hmset and hgetall to pass args #330

merged 7 commits into from
Oct 7, 2019

Conversation

kbaum
Copy link
Collaborator

@kbaum kbaum commented Oct 6, 2019

Uses about 25% less cpu on redis instance:

Before on master:

image

  coverband git:(master) COVERBAND_HASH_REDIS_STORE=t bundle exec rake benchmarks:redis_reporting
Warming up --------------------------------------
   store_reports_all     1.000  i/100ms
Calculating -------------------------------------
   store_reports_all      3.871  (±25.8%) i/s -     56.000  in  15.148240s
Warming up --------------------------------------
store_reports_subset     7.000  i/100ms
Calculating -------------------------------------
store_reports_subset    109.200  (±12.8%) i/s -      2.149k in  20.008229s

On this branch:

image

➜  coverband git:(change_to_hash) COVERBAND_HASH_REDIS_STORE=t bundle exec rake benchmarks:redis_reporting
runs benchmarks on reporting large sets of files to redis
Warming up --------------------------------------
   store_reports_all     1.000  i/100ms
Calculating -------------------------------------
   store_reports_all      2.319  (± 0.0%) i/s -     35.000  in  15.179692s
Warming up --------------------------------------
store_reports_subset     6.000  i/100ms
Calculating -------------------------------------
store_reports_subset     60.083  (±10.0%) i/s -      1.194k in  20.056954s

Seems a little slower

@kbaum kbaum changed the base branch from master to run_lua_tests_on_travis October 6, 2019 19:55
@kbaum kbaum changed the base branch from run_lua_tests_on_travis to master October 6, 2019 19:58
Copy link
Owner

@danmayer danmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@kbaum kbaum merged commit 7a5709a into master Oct 7, 2019
@kbaum kbaum deleted the change_to_hash branch October 7, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants