Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File number not updating when manually deleting the backups #10

Closed
iptvcld opened this issue Feb 11, 2020 · 8 comments
Closed

File number not updating when manually deleting the backups #10

iptvcld opened this issue Feb 11, 2020 · 8 comments

Comments

@iptvcld
Copy link

iptvcld commented Feb 11, 2020

File number not updating when manually deleting the backups

  • I was testing the backupall.php and made a bunch of backups then manually deleted the backups from the backups folder but the file number on the GUI still says 11.
@danmed
Copy link
Owner

danmed commented Feb 11, 2020

It will update the next time you make a backup.. It only checks at the time of backup.

@iptvcld
Copy link
Author

iptvcld commented Feb 11, 2020

So i did a full backup again and the number went to 12 but yet in my folder i just have the 1 backup

@iptvcld
Copy link
Author

iptvcld commented Feb 11, 2020

Also i noticed that the Backup Max Count field does not seem to work. I have it set to 5 and yet i was able to make more than 5 backups; it was not deleting the oldest. Thanks

@danmed
Copy link
Owner

danmed commented Feb 11, 2020 via email

@danmed
Copy link
Owner

danmed commented Feb 11, 2020

So, deleting the backups manually is just going to mess things up.. so the other contributor has pushed some code so that when you delete the device from the gui, it'll delete all the backups too.

Tomorrow i'll work on being able to delete indivudla backups, so that should remove the need to do anything manually.

as for the max backups, that only kick sin on a backup all, not individual backups.. we dont want to restrict you doing individual backups as it may be because you're about to make a change.

@iptvcld
Copy link
Author

iptvcld commented Feb 11, 2020

Thanks for looking into this! That delete backup option would be awesome.

  • As for Max backups; i am using the backupall.php and its still surpassing the max backup count. I even just pressed on the backup all button and it went past 5 even though my max is set to 5.

@danmed
Copy link
Owner

danmed commented Feb 11, 2020

Ok, I'll take a look at that too..

the delete option is now done.. it's building and should be available in a few mins.
Deleting a device gets rid of all the backups (without confirmation at the moment) and on the list backups page, you can delete individual ones.

I'll open another issue for the max backups

@iptvcld
Copy link
Author

iptvcld commented Feb 11, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants