Bundle external sources

[newhinton]

Quiet useful!
However, currently this service makes requests to:
ajax.googleapis.com
bootstrapcdn.com
datatables.com
googletagmanager.com

I dont think this app requires any of the above to be external, especially the tracking. Could you bundle bootstrap and such together so that this app is still usable in a network that does not allow connections to those sites?

[danmed]

Good point, thanks for pointing it out. I'll get that worked on.

[danmed]

Latest commit moves all bootstrap resources into container.

[newhinton]

@danmed Great!

On a sidenote, do you want a more technical review? (you asked on reddit for feedback)
I could give you some hints on how to improve one or two things, if you want help. (I could also help you out here and there, if you want that)

[danmed]

Hey, i've got a guy helping me optimise things already but i'm open to any and all ideas in theory :)

just working on exporting and importing to and from csv at the moment.

[newhinton]

Okay :D
Generally, it comes down to those two points:

• general structure of this project. Currently each and every file is in the root-folder of this repo. This is fine when the project is small, but generally it is more easily maintainable if there is a seperation of filetypes, something like js, css, html, installer database, you get the drill :D

• index.php
  this one is also part of the application-structure, but more on the codeside of things. Currently most of the important stuff happens there, which is fine by itself, but again it can get hard to expand it in the future. Maybe it would be easier to use a php-framework that takes care of some of the "basetasks" that you need to manage. I had some problems with an application which would have been easily solved with a framework.

Those are my two cent's and if you want help doing those suggestions, i'm happy to help out! :D

[danmed]

thanks for the hints. I know my structure and code is all over the place and the other guy i periodically cleaning it up. To be honest i'm close to having this as far as i'm going to take it other than a couple of extra features.. but i'll keep what you've said in mind.