Skip to content

Commit

Permalink
Adjust remaining :sync usage
Browse files Browse the repository at this point in the history
  • Loading branch information
dannon committed Apr 26, 2024
1 parent 9d0a44b commit 57d93c1
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 8 deletions.
2 changes: 1 addition & 1 deletion client/src/components/Common/FilterMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ function updateFilterText(newFilterText: string) {
v-if="
(props.view === 'popover' && toggleMenuButton) || props.menuType == 'standalone' || props.showAdvanced
"
v-model:show="localAdvancedToggle"
class="mt-2"
:show.sync="localAdvancedToggle"
:target="toggleMenuButton"
placement="bottomleft"
data-description="advanced filters"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function onViewCollection(collection: object) {
<div v-else id="list-item" class="d-flex flex-column align-items-center w-100">
<CollectionPanel
v-if="selectedCollections.length && selectedCollections[0]?.history_id === source.id"
v-model:selected-collections.sync="selectedCollections"
v-model:selected-collections="selectedCollections"
:history="history"
:show-controls="false"
@view-collection="onViewCollection" />
Expand Down
13 changes: 9 additions & 4 deletions client/src/components/Panels/MultiviewPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ function userTitle(title: string) {

<template v-slot:header>
<FilterMenu
v-model:filter-text="filter"
v-model:show-advanced="showAdvanced"
class="mb-3"
name="Histories"
placeholder="search histories"
:filter-class="HistoriesFilters"
:filter-text.sync="filter"
:loading="historiesLoading || loading"
:show-advanced.sync="showAdvanced" />
:loading="historiesLoading || loading" />
<section v-if="!showAdvanced">
<BButton
v-if="route.path !== '/histories/view_multiple'"
Expand Down Expand Up @@ -156,6 +156,11 @@ function userTitle(title: string) {
</BBadge>
</div>

<HistoryList v-show="!showAdvanced" multiple :filter="filter" :loading.sync="loading" @setFilter="setFilter" />
<HistoryList
v-show="!showAdvanced"
v-model:loading="loading"
multiple
:filter="filter"
@setFilter="setFilter" />
</ActivityPanel>
</template>
2 changes: 1 addition & 1 deletion client/src/components/Panels/ToolPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ function onInsertWorkflowSteps(workflowId: string, workflowStepCount: number | u
<div class="unified-panel-header-inner mx-3 my-2 d-flex justify-content-between">
<PanelViewMenu
v-if="panelViews && Object.keys(panelViews).length > 1"
v-model:show-advanced="showAdvanced"
:panel-views="panelViews"
:current-panel-view="currentPanelView"
:show-advanced.sync="showAdvanced"
:store-loading="loading"
@updatePanelView="updatePanelView">
<template v-slot:panel-view-selector>
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/Workflow/Editor/Index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
@onRefactor="onRefactor"
@onShow="hideModal" />
<MessagesModal :title="messageTitle" :message="messageBody" :error="messageIsError" @onHidden="resetMessage" />
<SaveChangesModal :nav-url.sync="navUrl" :show-modal.sync="showSaveChangesModal" @on-proceed="onNavigate" />
<SaveChangesModal v-model:nav-url="navUrl" v-model:show-modal="showSaveChangesModal" @on-proceed="onNavigate" />
<b-modal
v-model="showSaveAsModal"
title="Save As a New Workflow"
Expand Down

0 comments on commit 57d93c1

Please sign in to comment.