Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Chat): correctly render when refreshing/visiting a conversation page #1037

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Oct 10, 2023

Reported on discord.

UI was not rendering messages when refreshing/visiting a conversation page.

messagesTree is null when user navigates, but not on page refresh. We only need to "navigate" when a user triggers navigation (new chat button or clicking on a conversation), not when the conversation page is visited/refreshed

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

manual testing, chrome source debugging

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila merged commit 495ac1b into main Oct 10, 2023
2 checks passed
@danny-avila danny-avila deleted the refresh-fix branch October 10, 2023 19:04
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant