Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent Message Misrouting on Conversation Refresh 🔄 #1217

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

danny-avila
Copy link
Owner

fix: Prevent Message Misrouting on Conversation Refresh 🔄

Summary

Addresses a critical bug where refreshing the conversation page led to messages being sent to a new, incorrect conversation. This bug fix ensures that the conversation state is preserved on refresh and integrated properly with remote model updates (/api/models).

This change further decouples the new UI route handling from routes/Root.tsx, which is for the better.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

To ensure the fix works as intended, the following testing process was performed:

  1. Opened a conversation within the application.
  2. Refreshed the page to simulate the user's refresh action.
  3. Sent a message to check if it is routed to the currently active conversation.

Instructions for reproducing the test:

  • Open any conversation in the application.
  • Refresh the browser page.
  • Send a new message and verify it is delivered to the correct conversation.

Test Configuration:

  • Browser: Chrome Version 104.0.5112.101
  • Server Environment: Localhost with a simulated connection to remote message handling services.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 4dab094 into main Nov 25, 2023
1 check passed
@danny-avila danny-avila deleted the fix-refresh-convo branch November 25, 2023 14:19
danny-avila added a commit to lgtm-hbu/LibreChat that referenced this pull request Jan 17, 2024
danny-avila added a commit to lgtm-hbu/LibreChat that referenced this pull request Jan 19, 2024
danny-avila added a commit to lgtm-hbu/LibreChat that referenced this pull request Jan 22, 2024
danny-avila added a commit to lgtm-hbu/LibreChat that referenced this pull request Jan 23, 2024
danny-avila added a commit to lgtm-hbu/LibreChat that referenced this pull request Jan 31, 2024
danny-avila added a commit that referenced this pull request Feb 5, 2024
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
danny-avila added a commit that referenced this pull request Feb 9, 2024
danny-avila added a commit that referenced this pull request Feb 11, 2024
danny-avila added a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant