fix: fonts warning #1318
Merged
fix: fonts warning #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning was:
files in the public directory are served at the root path.
Instead of /public/fonts/soehne-buch.woff2, use /fonts/soehne-buch.woff2.
|
thank you! Trying this out |
|
This test is failing (major blocker as build fails) and is not reproducible in the first place in my environment (no fonts warnings before your changes for me). However, it still works for me if I change I would edit your PR but no permission to do so. |
danny-avila
approved these changes
Dec 10, 2023
shortpoet
pushed a commit
to shortpoet/LibreChat
that referenced
this pull request
Dec 30, 2023
* fix: Fix a fonts warning
The warning was:
files in the public directory are served at the root path.
Instead of /public/fonts/soehne-buch.woff2, use /fonts/soehne-buch.woff2.
* See if it likes /fonts better
cnkang
pushed a commit
to cnkang/LibreChat
that referenced
this pull request
Feb 6, 2024
* fix: Fix a fonts warning
The warning was:
files in the public directory are served at the root path.
Instead of /public/fonts/soehne-buch.woff2, use /fonts/soehne-buch.woff2.
* See if it likes /fonts better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was getting this warning while running the frontend:
I fixed it by changing the resolver in vite.config.ts from 'public/fonts' to just 'fonts'
Change Type
Testing
Manual testing to verify no error and no change in how it looks.