Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 docs: Correct Google OAuth Callback URL Example #2311

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

peaster
Copy link
Contributor

@peaster peaster commented Apr 4, 2024

Summary

The Google OAuth documentation calls out github as the provider in the callback URL example. This may add confusion for some users during the set up process in Google Cloud. I've updated the example with google as the provider and checked that the other OAuth/OIDC markdown files all follow the same pattern.

Change Type

  • Documentation update

Testing

Viewed the affected markdown files to ensure correctness.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings

@danny-avila danny-avila changed the title 馃摑 docs: update example Google OAuth callback URL to reflect correct vendor 馃摑 docs: Correct Google OAuth Callback URL Example Apr 4, 2024
@danny-avila danny-avila merged commit daa5f43 into danny-avila:main Apr 4, 2024
@danny-avila
Copy link
Owner

thanks!

@peaster peaster deleted the docs/oauth-callbacks branch April 4, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants