Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§‘β€πŸŽ¨ style: Remove Plugins Icon Background #2368

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

mawburn
Copy link
Sponsor Contributor

@mawburn mawburn commented Apr 10, 2024

Closes: #2367

Summary

I removed the bg-white and dark:bg-gray-800 from the relevant images, but left it on the wrench. As noted in the ticket above, this is just a minor tweak that's been bothering me for a while.

Before:

old-list

old-plugin

After:

list

store

Copilot summary

This pull request primarily focuses on modifying the CSS classes of various img elements in the PluginStoreItem.tsx and MultiSelectPop.tsx files. The changes remove the bg-white class from these elements, which previously set the background color of the images to white.

Here are the key changes:

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code

@danny-avila danny-avila changed the title Remove Icon Background πŸ§‘β€πŸŽ¨ style: Remove Plugins Icon Background Apr 10, 2024
@danny-avila
Copy link
Owner

lgtm! thanks!

@danny-avila danny-avila merged commit f64a2cb into danny-avila:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mismatched colors for plugin icons on dark mode
2 participants